Combined FSTree versioning and log #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
roman-khimov
force-pushed
the
combined-versioning-and-log
branch
from
825eb5f to
dfa8068
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
- Coverage 22.64% 22.64% -0.01%
==========================================
Files 791 791
Lines 58618 58615 -3
==========================================
- Hits 13274 13271 -3
Misses 44447 44447
Partials 897 897 ☔ View full report in Codecov by Sentry. |
roman-khimov
force-pushed
the
combined-versioning-and-log
branch
from
6c3cef6 to
252fa85
Compare
carpawell
approved these changes
Nov 27, 2024
|
|
||
| // combinedPrefix is the prefix that Protobuf message can't start with, | ||
| // it reads as "field number 15 of type 7", but there is no type 7 in | ||
| // the system (and we usually don't have 15 fields). ZSTD magic is also | ||
| // different. | ||
| combinedPrefix = 0x7f | ||
|
|
||
| // combinedLenSize is sizeof(uint32), length is a serialized 32-bit BE integer. |
There was a problem hiding this comment.
Suggested change
| // combinedLenSize is sizeof(uint32), length is a serialized 32-bit BE integer. | |
| // combinedLenSize is sizeof(uint32), length of a serialized 32-bit BE integer. |
no?
Our real storages have nothing to report. Signed-off-by: Roman Khimov <[email protected]>
In case they want to log something. Signed-off-by: Roman Khimov <[email protected]>
It is important to know which type of the writer is used, they differ in characteristics. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Yeah, lengthy names, but it's better for future extensions. Signed-off-by: Roman Khimov <[email protected]>
We may want to have something more complex in future versions (like #2925 or others) and we don't have a lot of safe bytes to use in place of 0x7F. So let's have a byte for format version. This is an incompatible change, but this code was never in production. Signed-off-by: Roman Khimov <[email protected]>
When we already know that the file is combined (seen the prefix at least once, isCombined is true) we expect all subsequent entries to be proper combined ones as well. If they're not (wrong prefix) --- something is wrong with the file and returning it as is won't help. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
combined-versioning-and-log
branch
from
252fa85 to
b79dcfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.